feature/nl-net-injestion-injestor-update #10
puer-robustus
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/nl-net-injestion-injestor-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi @ijohn
Thanks for consolidating things into one PR.
Some comments:
data/projectsare materially wrong.grantid2project.pyscript, I'm not sure that looking for regex patterns is the most understandable way to parse the hex HTML. Why did you choose this route instead of HTML parsing via e.g. BeautifulSoup?scripts/ingest.pyI think we should use a different approach: The Hex parsing can (maybe?) help us maintain the PROJECT2GRANTS mapping, but the hex parsing results should never be used directly to generate the project jsons.@ -0,0 +1,3 @@# SPDX-FileContributor: Alex <alex@isoc.ch>This file is not needed anymore. I placed it there, before the
data/projectsdir contained files.@ -0,0 +1,13 @@{Something is wrong here. Arcan-A12 is one project with multiple grants. Your import splits this up again.
@ -13,0 +16,4 @@"https://nlnet.nl/project/Cuirass","https://nlnet.nl/project/GUIX-securitytracking","https://nlnet.nl/project/Guix-Riscv64","https://nlnet.nl/project/GuixDaemon-Guile",How do the unrelated Guix projects belong to "Cuirass"?
And as for the nlnet-mapping dir, I cannot really give feedback there as I don't know JavaScript. But if I understand correctly, this is more for building up a heuristic to map projects to categories? Why did this need to be a JavaScript app?
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.